On Thu, 25 Sep 2025 21:35:13 GMT, Kevin Rushforth <[email protected]> wrote:
>> Ambarish Rapte has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into gradle-900-warnings
>> - replace project.exec and project.javaexec
>
> build.gradle line 888:
>
>> 886: pkgdir.mkdirs()
>> 887: def execOps =
>> project.services.get(ExecOperations)
>> 888: execOps.exec { ExecSpec spec ->
>
> Suggestion:
>
> execOps.exec { spec ->
>
>
> We generally don't include the type of a closure argument, unless it's
> ambiguous (which I don't think it is here).
Thank you, removed the type from all such instances.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1918#discussion_r2382016497
