On Mon, 22 Sep 2025 23:52:21 GMT, Michael Strauß <[email protected]> wrote:
>> Given a media query with more than one rule:
>>
>>
>> @media (prefers-color-scheme: dark) {
>> .foo1 {
>> -fx-background-color: black;
>> }
>> .foo2 {
>> -fx-background-color: white;
>> }
>> }
>>
>>
>> The following CSS parser error is encountered: `Expected RBRACE`
>>
>> The reason for this bug is that the CSS parser mistakenly expects that after
>> the first rule was parsed, the media query should be terminated with a
>> closing curly brace. This is obviously incorrect, the fix is relatively
>> simple.
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> emit error when closing curly brace is missing
LGTM. Verified that with this change, nested `@media` queries with multiple
rules can be provided. Also, the older way of providing the `@media` query
separately for each rule also works fine.
-------------
Marked as reviewed by arapte (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1915#pullrequestreview-3298356969
