On Thu, 9 Oct 2025 17:16:22 GMT, Pabulaner IV <[email protected]> wrote:
> Thanks for the detailed feedback, much appreciated. So as far as I understood > Your feedback it means that the PR from Your side would be good to go, but > maybe in the future some minor bug / issue fixes would be nice to have? I need to do a more detailed review of the platform code but for now I haven't seen any problems with it. To review the changes to, say, _setMenubar I needed to first understand when it is called and that's what I was focusing on. There is an unexpected testing burden. When a popup appears in an FXPanel (as a tooltip, combo box, or menu) the core code will try to set the system menu bar for no good reason and it's up to the platform code to make sure it doesn't succeed. I'm not sure it warrants a system test but some testing needs to be done for these cases. This core behavior really should be addressed in a follow up issue but that's not something I can do until November. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1904#issuecomment-3396166710
