On Wed, 15 Oct 2025 19:07:13 GMT, Marius Hanl <[email protected]> wrote:

>> We should be careful not to over-specify this. The "in other words" part 
>> already suggests what it does. Maybe it could be made more explicit by 
>> adding "to match the underlying data source", like this?
>> 
>> 
>>      * In other words, this forces the TableView to update what it is 
>> showing to
>>      * the user to match the underlying data source.
>>      * This is useful in cases where the underlying data source has
>>      * changed in a way that is not observed by the TableView itself.
>
> I like this idea.
> If we want to explain what rebuild does, I would probably mention that this 
> means the cells are updated. So maybe instead of `rebuild`, we could use 
> something like `re-update`, maybe?

Yes, mentioning that the cells are updated is good (and is what I was trying to 
add). I'd stick with "rebuild" in the first sentence, though, since that is 
used in VirtualFlow.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1830#discussion_r2434010757

Reply via email to