On Thu, 23 Oct 2025 19:57:10 GMT, Andy Goryachev <[email protected]> wrote:
>> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains eight additional >> commits since the last revision: >> >> - Merge branch 'master' into feature/bulk-listeners >> - remove unused variable >> - Don't repeatedly call backingSet.size() >> - Separate code paths for Change/IterableChange >> - Use MapListenerHelper in PlatformPreferences to support bulk change >> notifications >> - Factor out IterableSetChange/IterableMapChange implementations >> - add tests, documentation >> - Implementation of bulk change listeners for ObservableSet and >> ObservableMap > > modules/javafx.base/src/main/java/javafx/collections/MapChangeListener.java > line 107: > >> 105: * Repeatedly calling this method allows a listener to fetch >> all subsequent changes of a bulk >> 106: * map modification that would otherwise be reported as >> repeated invocations of the listener. >> 107: * If the listener only fetches some of the pending changes, >> the rest of the changes will be > > suggestion: > If the listener only fetches some of the pending changes **via the XX() > method** > ? Hmm... there's no other method to call in order to fetch more changes. I could add "If the listener only fetches some of the pending changes **with the next() method**". But then again, just in the sentence before we explained that fetching more changes is done by "repeatedly calling this method" (i.e. the `next()` method). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1885#discussion_r2457916284
