On Wed, 29 Oct 2025 12:55:57 GMT, Kevin Rushforth <[email protected]> wrote:
>> Adds Input Method Editor (IME) support to `RichTextArea`/`CodeArea`. >> >> Tested on macOS and Windows 11 with Japanese and Chinese (pinyin) input >> methods. >> Please test this on Linux, even though there is no platform-specific code in >> this PR (should work the same way it does in `TextArea`/`TextField`) >> >> For testing, one can use the updated Monkey Tester >> https://github.com/andy-goryachev-oracle/MonkeyTest >> (optionally enable IME events in stdout with Logging -> IME Monitor) > > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/RichTextArea.java > line 1438: > >> 1436: * @param sb the buffer to copy to >> 1437: * @param limit the maximum number of characters to copy, must be >> >= 0 >> 1438: * @param lineSeparator the newline separator sequence, or null to >> use the platform default > > Whether and how to add lineSeparator is under review via PR #1944. I > recommend removing everything related to line separators for this PR, unless > you want this PR to be dependent on #1944. This and #1944 interrelated. Ideally, this PR should go first. > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/RichTextArea.java > line 1442: > >> 1440: * @since 26 >> 1441: */ >> 1442: // TODO depends on JDK-8370140 (line separator property), private >> for now > > While a `getText(...)` method would be useful, I don't see an enhancement > request that proposes it. I would make it more clear that this is not public > API. If you want to leave the docs in place for a future enhancement that > might provide such a public API, I recommend changing `@since 26` to `@since > 99` (or similar). correct, this is not a public API (yet). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1938#discussion_r2474425664 PR Review Comment: https://git.openjdk.org/jfx/pull/1938#discussion_r2474429640
