On Thu, 6 Nov 2025 11:23:13 GMT, Ambarish Rapte <[email protected]> wrote:

>> - Updated libFFI to 3.5.2.
>> - Tested on all platforms.
>> - No additional changes are done.
>
> modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/aarch64/internal.h
>  line 93:
> 
>> 91:   #define SIGN_LR_LINUX_ONLY
>> 92: #define BRANCH_TO_REG braaz
>> 93:   #define PAC_CFI_WINDOW_SAVE
> 
> Minor: 
> Looks like the upstream libffi file has some specific space additions in this 
> file to showcase nesting. So, to match it, Line 86 to 90, line 92, should 
> also be modified to have prefixing space.
> Similar applies to line 135 to 142.
> 
> It may help reducing conflicts during next update.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1962#discussion_r2501225852

Reply via email to