On Wed, 12 Nov 2025 19:05:30 GMT, Kevin Rushforth <[email protected]> wrote:
>> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >> commits since the last revision: >> >> - documentation >> - Merge branch 'master' into feature/extended-dialog >> - move HeaderBar to DialogPane >> - document/verify preview feature >> - Ensure that DialogPane is always attached to Scene >> - Lazily initialize Dialog.headerBar >> - Support dialogs with StageStyle.EXTENDED > > modules/javafx.controls/src/main/java/javafx/scene/control/DialogPane.java > line 221: > >> 219: headerTextPanel = new GridPane(); >> 220: headerTextPanel.setVisible(false); >> 221: headerTextPanel.setManaged(false); > > Why was this change needed? At first glance it seems unrelated to supporting > an (optional) header bar. This was left over from a previous bug-fixing attempt. I've removed the added code. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1943#discussion_r2522779075
