On Mon, 1 Dec 2025 21:09:52 GMT, Andy Goryachev <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > modules/javafx.graphics/src/test/java/test/javafx/scene/NodeTest.java line > 1626: > >> 1624: assertEquals(minY, b.getMinY(), 0.0005); >> 1625: assertEquals(width, b.getWidth(), 0.0005); >> 1626: assertEquals(height, b.getHeight(), 0.0005); > > maybe we could declare a static constant EPSILON and use it at least in the > modified tests? Since there are many different epsilons used in this test class, I'd have to call it something specific like `EPSILON_0005`, and at that point, there's little difference between a numeric literal and a constant field. It's a bit like saying "ONE" instead of "1". ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1992#discussion_r2578887532
