> Addressing the user feedback: > > In RichParagraph you have a note to make getSegments() public. It would be > helpful if it was. > > > Adding two methods to the `RichParagraph` class: > > - getSegmentCount() > - getSegment(int index) > > Decided against exposing a List since it would require additional allocation. > Some of the callers seems to implement special logic when the number of > segments is 0 anyway.
Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision: npe ------------- Changes: - all: https://git.openjdk.org/jfx/pull/1966/files - new: https://git.openjdk.org/jfx/pull/1966/files/b4691640..64f7836d Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1966&range=05 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1966&range=04-05 Stats: 4 lines in 2 files changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jfx/pull/1966.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1966/head:pull/1966 PR: https://git.openjdk.org/jfx/pull/1966
