On Sun, 21 Dec 2025 02:42:12 GMT, Cormac Redmond <[email protected]> wrote:

> Fix overflow menu triggering due to floating-point precision error.
> 
> At 1.25 display scaling on Windows, floating-point comparison errors (e.g. 
> 109.60000000000001 > 109.6) cause the overflow menu to appear when the 
> lefthand value is regarded as larger than the righthand value.
> 
> These should be treated as equal (and therefore not display the overflow 
> menu).
> 
> This bug can happen in both horizontal and vertical toolbar orientation.
> 
> The new tests added fail without this fix, and pass with it. An existing test 
> has been re-factored slightly to allow re-use and more flexibility in 
> specifying the scene's root node.

Fun fact: check out the failure mode in 
https://bugs.openjdk.org/browse/JDK-8356570 - though not directly related to 
snapping, the naive implementation is nevertheless faulty.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/2016#issuecomment-3682910392

Reply via email to