On Sun, 21 Dec 2025 22:08:33 GMT, John Hendrikx <[email protected]> wrote:
>> An example of length rounding due to "-=" operations (again, at 1.25 scale), >> when overflow should show: >> >> <img width="855" height="247" alt="image" >> src="https://github.com/user-attachments/assets/aca455ab-0d32-4e46-9868-78d786cd4a7b"; >> /> >> >> I can't (easily) get it to create any actually problems for me, but the >> question remains, should be re-snap it also? >> >> If it's not (demonstrably) broken, don't fix it, maybe. > > Yeah, that's going to cause problems at some point. It must be resnapped > when doing comparisons with it. @hjohn: I appreciate the above is a lot of text (this close to Xmas!)... I went ahead and made the changes so it's easier to see just the diff: https://github.com/openjdk/jfx/pull/2016/files ... I can revert if I am wrong. I think it's safe, and the simplest change to fix both `length` and `x` issues. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2016#discussion_r2641123623
