On Mon, 22 Dec 2025 21:51:14 GMT, Kevin Rushforth <[email protected]> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 12 commits: >> >> - javadoc >> - cleanup >> - Merge branch 'master' into 8366198.rbuilder >> - rich paragraph builder api >> - Merge branch 'master' into 8371070.enhance >> - npe >> - merge >> - Merge branch 'master' into 8371070.enhance >> - Merge branch 'master' into 8371070.enhance >> - Merge branch 'master' into 8371070.enhance >> - ... and 2 more: https://git.openjdk.org/jfx/compare/03612e1b...05136fe1 > > modules/jfx.incubator.richtext/src/shims/java/jfx/incubator/scene/control/richtext/model/RichTextModelShim.java > line 29: > >> 27: >> 28: public class RichTextModelShim { >> 29: // > > Are you leaving this class as a placeholder or do you have plans to put > something here in the near future? Either way, I suppose there's no real harm > in leaving it. That's correct - I left it so as not to disturb the directory structure. The purpose of shims is to allow tests to access internals, something that we do in other parts of the code, though I find this practice questionable. I'd rather use public APIs for tests. In any case, there might be a need for the shims in the future, and if not we can clean it up when/if the feature graduates from the incubator. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1966#discussion_r2641388838
