On Tue, 23 Dec 2025 22:14:32 GMT, Andy Goryachev <[email protected]> wrote:
>> Fixed two crashes:
>> - `shouldWaitForLoadingOfRequestedResource()` was not synchronized with
>> `dispose()`.
>> - `AddBand()`, `RemoveBand()` and `MoveBand()` was not synchronized with
>> `ProcessBufferLists()`.
>
> modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioEqualizer.h
> line 155:
>
>> 153:
>> 154: void lockBands() {
>> 155: pthread_mutex_lock(&mBandLock);
>
> I assume `int pthread_mutex_[lock|unlock]()` returns some kind of error code.
> should we check it?
Maybe. Other code we have does not check it.
https://github.com/openjdk/jfx/blob/master/modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioSpectrumUnit.h#L112
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2008#discussion_r2644375446
