On Wed, 15 Oct 2025 17:14:37 GMT, Kevin Rushforth <[email protected]> wrote:

>> Considering that the \"left\" and \"right\" terminology is deeply
>> entrenched in JavaFX\, I see no advantage in trying to fight it\.
>> However\, I agree that we should clearly define what left and right
>> means in the context of RTL layouts\, which is a bit different from the
>> usual dictionary definition of left and right\.
>> 
>> 
>> On Tue\, Oct 14\, 2025 at 7\:08\?PM Andy Goryachev
>> \<andy\.goryachev at oracle\.com> wrote\:
>>>
>>> I would rather clarify the incorrect labels in the existing components\.  
>>> We obviously cannot change setLeft\(\) \- perhaps we should add explanation 
>>> to the corresponding javadoc explaining RTL behavior\.  I would like to 
>>> avoid making the same mistake going forward\.
>>>
>>> \-andy
>
>> Considering that the "left" and "right" terminology is deeply entrenched in 
>> JavaFX, I see no advantage in trying to fight it. However, I agree that we 
>> should clearly define what left and right means in the context of RTL 
>> layouts, which is a bit different from the usual dictionary definition of 
>> left and right.
> 
> I think this is a good choice from a consistency point of view.

@kevinrushforth I think this PR has evolved nicely, and incorporates quite a 
bit of feedback we've received so far. Do you have the chance to look at the 
CSR in the next few days, so that I can finalize it this week?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1936#issuecomment-3712415764

Reply via email to