On Mon, 29 Dec 2025 09:10:39 GMT, Pabulaner IV <[email protected]> wrote:
>> Pabulaner IV has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new commit since the last revision: >> >> 8359108: Mac - When Swing starts First, native application menu doesn't >> work for JavaFX > > Thanks for the fast reply! > > I have removed all external dependencies and added a main method to each > test. > I also have added a README.md on how to compile and run the tests, since You > need to add the javafx modules. @pabulaner The latest version of the tests build and run fine for me. Thanks! I'll do some additional testing and complete my review very soon. In the mean time, can you do two thing? 1. Enable GitHub Actions (GHA) Workflows in your personal fork. This will allow sanity tests to run when you push code changes to your branch of your personal fork, and allow the Skara bot to report the results of the tests in the PR. Navigate to the home page of your GitHub repo, click on the "Actions" tab, and then click on the green button that says something like: "I understand my workflows, go ahead and enable them". 2. Merge (not rebase) the latest upstream master into your branch and push it. That will trigger a GHA test run on your now-up-to-date branch. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1904#issuecomment-3720107970
