On Thu, 8 Jan 2026 01:52:19 GMT, Michael Strauß <[email protected]> wrote:
>> The `HeaderBar` control currently has three areas: `leading`, `center`, and >> `trailing`. Additionally, there's `leftSystemInset` and `rightSystemInset`, >> which are not RTL adjusted. I've come to the understanding that there is no >> particularly good reason for this, because every time you would want to use >> this information for layout purposes, it should also be adjusted for RTL. >> >> With this in mind, there are three changes for the `HeaderBar` control: >> 1. Rename `leading` to `left`, and `trailing` to `right`, which aligns the >> terminology with `BorderPane`. >> 2. Adjust `leftSystemInset` and `rightSystemInset` for RTL. >> 3. Make `leftSystemInset`, `rightSystemInset`, and `minSystemHeight` >> attached properties for `Stage`. >> >> With this change, the `HeaderBar` control is more semantically consistent >> and easier to use, and the renamed `left` and `right` areas now show its >> close relationship with `BorderPane`. >> >> In addition to that, two new `HeaderDragType` constants are added: >> * `TRANSPARENT`: when set on a node, excludes the node from draggable-area >> hit testing >> * `TRANSPARENT_SUBTREE`: the same, but also applies to the node's subtree > > Michael Strauß has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 20 additional > commits since the last revision: > > - move-modal message loop > - Merge branch 'master' into headerbar-update > - update copyright year to 2026 > - use native constants > - typo > - align Linux/Windows behavior when clicking on resize border > - documentation > - Unspecified HeaderDragType is behind top resize border > - documentation > - documentation > - ... and 10 more: https://git.openjdk.org/jfx/compare/c550559e...7a18278f modules/javafx.graphics/src/main/native-glass/win/GlassWindow.cpp line 689: > 687: // We don't consume this message, so it will be handled as usual > in HandleViewMouseEvent() > 688: // to generate a normal JavaFX event. Note that > HandleViewMouseEvent() calls SetCapture(). > 689: case WM_LBUTTONDOWN: Do we need to handle any other mouse events here (wheel, horizontal scroll, etc)? I do see the horizontal scroll happening in the client area outside of the header bar when I first click and hold the left mouse button inside the header bar text field (i.e. inside a drag event), but this behavior is exhibited elsewhere. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1936#discussion_r2673180648
