On Mon, 12 Jan 2026 19:37:57 GMT, Christopher Schnick <[email protected]> wrote:

>> This PR replaces various catch blocks for NPEs by proper null checks. It 
>> looks like a lot but most of the binding changes are just variants of the 
>> same approach. The test cases have been adapted to not check for NPEs 
>> anymore.
>> 
>> The PrismFontFactory change to a RuntimeException was made because I don't 
>> see how the try block can throw an NPE.
>
> Christopher Schnick has updated the pull request incrementally with two 
> additional commits since the last revision:
> 
>  - Fix visibility
>  - Fixes

This will need careful review, and probably additional tests, to ensure that 
there are no regressions or changes in behavior.

We will need to run it through our headful test system as well, since headless 
sanity testing is not going to be sufficient here.

This isn't something I want to do quickly, so this will need to wait until 
after the jfx26 fork and we have sufficient time to test it.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/2032#issuecomment-3741067839

Reply via email to