On Tue, 13 Jan 2026 00:16:11 GMT, Kevin Rushforth <[email protected]> wrote:

>> modules/javafx.base/src/test/java/test/com/sun/javafx/runtime/VersionInfoTest.java
>>  line 41:
>> 
>>> 39: 
>>> 40:     // Increment this feature-release counter for every major release.
>>> 41:     private static final String FEATURE = "27";
>> 
>> minor suggestion: maybe add a comment listing all the files that need to be 
>> updated?  not sure where though.
>
> Already implemented. See 
> [UPDATING-VERSION.md](https://github.com/openjdk/jfx/blob/master/UPDATING-VERSION.md)

yes, but assumes prior knowledge - it is not apparent in the github review.  a 
reference to 
[UPDATING-VERSION.md](https://github.com/openjdk/jfx/blob/master/UPDATING-VERSION.md)
 would work though.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2033#discussion_r2686896494

Reply via email to