On Wed, 14 Jan 2026 19:12:10 GMT, Kevin Rushforth <[email protected]> wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed deprecataions.
>
> modules/javafx.graphics/src/main/java/javafx/scene/input/KeyCode.java line
> 625:
>
>> 623: * @deprecated Use {@link KeyCode#UP} instead.
>> 624: */
>> 625: @Deprecated
>
> Please add a `since` parameter to the `Deprecated` annotations, which is the
> release in which it is deprecated. Given where we are in the release, this
> would be `@Deprecated(since = "27")`, since it is too late for an enhancement
> with a deprecation to get into 26 (unless it were deemed important enough,
> which this doesn't seem to be).
I've removed the deprecations for now. That might be the best thing going
forward, references to these constants are benign and there's no point in
churning the code to remove them.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2036#discussion_r2691959959
