On Thu, 15 Jan 2026 15:29:14 GMT, Florian Kirmaier <[email protected]>
wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/LabeledImpl.java
>> line 61:
>>
>>> 59:
>>> 60: labeledImpl.textTruncatedProperty().subscribe(v -> {
>>> 61: LabeledHelper.setTextTruncated(labeled, v);
>>
>> should the property be bound instead?
>
> This is going through the Accessor pattern of Labeled.
> I could extend it, to return the BooleanProperty and use it.
> Should i?
oh, right, I forgot it's a read-only property (and I should know).
let me take a look, at first glance it looks right.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2040#discussion_r2694871584
