On Thu, 12 Mar 2026 15:16:17 GMT, Andy Goryachev <[email protected]> wrote:
>> This PR removes the obsolete caller class field from the FXMLLoader as it is >> requested by the ticket and comment in the class. The caller class loader in >> the ControllerAccessor is therefore obsolete and has been removed as well. >> >> Edit: I've found another caller parameter in getDefaultClassLoader(), which >> was always null. Also removed :) > > modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1147: > >> 1145: fxmlLoader.setStaticLoad(staticLoad); >> 1146: >> 1147: Object value = fxmlLoader.loadImpl(); > > Line 2: please update copyright year > ` * Copyright (c) 2010, 2026, ` It seems we now have multiple understandings if we still need to adjust it or not. See: https://github.com/openjdk/jfx/pull/2007#issuecomment-3909493678 which references: https://github.com/openjdk/jfx/pull/1236#issuecomment-2075209373 Maybe we should have a short agreement on the mailing list about that? Because since that comment, I do not look about the changed copyright year anymore. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2099#discussion_r2925945587
