On Tue, 17 Mar 2026 14:48:07 GMT, Ambarish Rapte <[email protected]> wrote:

>> Jose Pereda has updated the pull request incrementally with two additional 
>> commits since the last revision:
>> 
>>  - undo change
>>  - Address feedback
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/MenuBarSkin.java
>  line 515:
> 
>> 513:             // If an owned dialog is shown, the owner stage should keep 
>> it as it was.
>> 514:             return;
>> 515:         }
> 
> minor recommendation :
> The if else block could be changed to :
> 
> 
> if (stage != null) {
>     if (staged.isFocused()) {
>         ...
>     } else {
>         return;
>     }
> }

done

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2107#discussion_r2947870633

Reply via email to