On Fri, 20 Mar 2026 18:46:10 GMT, Andy Goryachev <[email protected]> wrote:
>> - Fixed potential NULL pointer dereference. >> - Tested on all platforms with all supported media files. > > modules/javafx.media/src/main/native/gstreamer/gstreamer-lite/gstreamer/gst/gstcapsfeatures.c > line 808: > >> 806: #ifdef GSTREAMER_LITE >> 807: if (!feature_str) >> 808: return 0; > > Probably does not matter - is it 0 or `NULL`? > > (I see L882 compares it to `NULL`) `g_return_val_if_fail (features != NULL, 0)` will return 0 if we pass `NULL` to this function. When fixing NULL pointers I am returning same value as other checks for errors or `NULL`. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2114#discussion_r2968359290
