On Wed, 22 Apr 2026 11:45:25 GMT, Lukasz Kostyra <[email protected]> wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rollback some changes
>
> modules/javafx.graphics/src/main/native-glass/gtk/glass_general.h line 295:
>
>> 293: #else
>> 294:
>> 295: #define LOG(...) ((void)0)
>
> Minor: while it probably won't matter much right now, a preferred syntax here
> is:
>
>
> #define LOG(...) do {} while(0)
>
>
> It compiles to the same thing (a noop) but it is the most language-conforming
> statement that can be used basically anywhere without triggering a sudden
> compiler error. Here there could be a problem when for example we would try
> to do:
>
> if (cond)
> LOG("success");
> else
> LOG("error");
>
>
> As a side-note, this also should apply to other LOG macros in this file, but
> we already have [JDK-8356327](https://bugs.openjdk.org/browse/JDK-8356327)
> for this, so you can leave them and it will get adjusted there.
Done
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2139#discussion_r3138593380
