On Mon, 30 Mar 2026 21:28:41 GMT, Christopher Schnick <[email protected]> 
wrote:

>> This fixes a regression caused by the fix for 
>> https://bugs.openjdk.org/browse/JDK-8282290. The old if else block was 
>> broken by the other PR, which caused the calculation for the caret width to 
>> be never run.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Christopher Schnick has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Clarify if else flow

Looks good to me too and I like the new code more, as it is easier to 
understand just by reading the variable names.

If you like, you can adjust the copyright header (year), will reapprove if you 
do.

-------------

Marked as reviewed by mhanl (Committer).

PR Review: https://git.openjdk.org/jfx/pull/2128#pullrequestreview-4211885763

Reply via email to