On Wed, 6 May 2026 19:13:41 GMT, Christopher Schnick <[email protected]> wrote:
>> This PR adds a missing call to update the display value to the converter >> property listener >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Christopher Schnick has updated the pull request incrementally with one > additional commit since the last revision: > > Update javadocs I will need to test it, here are some some preliminary comments - modules/javafx.controls/src/main/java/javafx/scene/control/ComboBox.java line 325: > 323: * > 324: * When the ComboBox is {@link #editableProperty() editable}), the > converter is used > 325: * to convert the input to an object of type T, such that the input > may be retrieved I like the new javadoc very much, thank you! the only nitpick is "the converter is used to convert", can it be re-phrased? modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java line 338: > 336: } > 337: > 338: @Test public void testCellUpdateOnStringConverterChange() { could you move the `@Test` annotation to its own line here and L363 please? ------------- PR Review: https://git.openjdk.org/jfx/pull/2165#pullrequestreview-4238923412 PR Review Comment: https://git.openjdk.org/jfx/pull/2165#discussion_r3196971987 PR Review Comment: https://git.openjdk.org/jfx/pull/2165#discussion_r3196977123
