On Fri, 8 May 2026 22:32:33 GMT, Alexander Zuev <[email protected]> wrote:
>> - Create implementation of protocol; >> - Wire new implementation to TEXT_AREA and TEXT_FIELD roles; >> - Add supporting method to store and request java side role; >> - Add method to retrieve node attribute for the specified parameter; >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > - Fix issue where VoiceOver treats non-editable text element as editable. > Both ways of shielding setters and an old style selector returning if value > is settable are required to work on all supported macOS versions. I see not a single difference in VoiceOver between the master and this PR on macOS 26.4.1 M1. I guess this is expected? Tested `TextArea`, `TextField`, `PasswordField` with the `editable` property on/off. Left very minor formatting comments which can be ignored. modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line 142: > 140: * Code that uses this function needs to convert NULL to the default > value of a certain type where required. > 141: */ > 142: minor: extra newline modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line 149: > 147: jobject jresult = (jobject)(*env)->CallLongMethod(env, [self > getJAccessible], > 148: > jAccessibilityAttributeValueForParameter, > 149: (jlong)attribute, > (jlong)parameter); very minor: parameter alignment. The coding style calls for aligning wrapped parameters on the first one, but I don't like this idea at all: one refactoring and the alignment is out of whack. What I would propose to do is to offset by one tab (four spaces), and also place each parameter on its own line: jobject jresult = (jobject)(*env)->CallLongMethod( env, [self getJAccessible], jAccessibilityAttributeValueForParameter, (jlong)attribute, (jlong)parameter); (one hidden benefit of this style is that one can add comment to individual arguments) Having said all this, the current indentation is also acceptable to me. ------------- Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2130#pullrequestreview-4274651701 PR Review Comment: https://git.openjdk.org/jfx/pull/2130#discussion_r3228440396 PR Review Comment: https://git.openjdk.org/jfx/pull/2130#discussion_r3228475039
