On Tue, 12 May 2026 16:03:36 GMT, Ambarish Rapte <[email protected]> wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed Widths change
>
> tests/system/src/test/java/test/robot/javafx/scene/TextFieldCaretVisibilityTest.java
> line 49:
>
>> 47: private static final double MARGIN = 2.0;
>> 48:
>> 49: private static final double[] TEST_WIDTHS = { 600, 50 };
>
> A minor observation, the width of stage in RobotTestBase class is 400. So,
> the TEST_WIDTHS=600 won't really get applied to TF. The size of TextField
> gets restricted to 400, which seems ok as a test.
Yes true, but we can keep it to ensure that the caret is always visible even in
the case of TextField width higher than the stage.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2157#discussion_r3229126245
