On Mon, 18 May 2026 15:11:20 GMT, Andy Goryachev <[email protected]> wrote:
> `menuGraphicFactoryOverride` might be a better name, I agree - that what it > is designed to be, an override. > > There is one possible use case which favors a factory over an override: when > the application is too lazy to implement the whole factory, wanting instead > to handle the custom tabs, delegating the other kinds to the default factory. > Not the use case I initially envisioned, but it is a possibility that > suggests exposing a `DEFAULT_MENU_GRAPHIC_FACTORY` might be a better approach. I didn't think of this use case, but it seems reasonably useful for developers who just want to keep the default factory implementation, but just add one more thing to it. > One more point I wanted to bring up is the use of `Callback` instead of a > dedicated interface - we had this problem when adding table column resize > policies. A `Callback` cannot be evolved, while a dedicated interface can, > using default methods. I don't think this should be the case here since the > functionality is very limited, but I want to bring it to your attention. While `Callback` can't be evolved, it can conceivably be extended by another interface. But I agree that this probably isn't relevant for this use case. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1773#issuecomment-4479593935
