On Wed, 20 May 2026 02:40:23 GMT, Alexander Matveev <[email protected]> wrote:
>> - Removed/disabled coded which uses `gunichartables.h`. We do not use it and >> do not need. >> - Only dependency on this code is `GVariant` which uses `g_unichar_isprint` >> to determine if character can be printed or needs to be escaped. This code >> is not being used currently, but might be in the future. Assert which >> validates `GVariant` string uses it to log value of `GVariant` in case if >> assert fails. We might need it someday, so I keep it. Code was updated to >> use if ascii is printable instead, since we do not use any unicode in our >> code. In worst case we will escape non-ascii characters in debug log. >> - I tested on all platforms with all supported formats. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8379561: Remove UNICODE related code from GLib [v5] LGTM ------------- Marked as reviewed by lkostyra (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2168#pullrequestreview-4328051953
