On Wed, 20 May 2026 17:53:55 GMT, Martin Fox <[email protected]> wrote:
> I thought about this but only in the context of the default skin (I doubt we > want to encourage clients to attach event listeners to random parts of the > skin we create). I forgot that clients can create their own skins and may > want to attach filters and handlers. I could alter the code so the dispatch > chain covers the entire skin. > > Just to be clear I don't like the solution in this PR. I began prototyping > some cleaner approaches but was stymied by the control/skin/behavior split > which is particularly murky with ComboBox and Spinner. These skins are also > playing games with the way they handle ENTER and ESCAPE which would also need > to be re-worked. For a bugfix, I'm generally okay with any of the possible approaches: 1) do nothing, 2) send the event directly to the target, or 3) dispatch it through the skin subgraph. Since I don't _like_ any of the solutions, I have no clear preference for or against any of them. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2166#issuecomment-4501737693
