On Wed, 20 May 2026 22:00:40 GMT, Andy Goryachev <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> verify that malformed queries evaluate to false
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/media/MediaQueryParser.java
> line 109:
>
>> 107:
>> 108: while (stream.consumeIf(NOT_COMMA) != null) {
>> 109: // Skip forward to the next comma and
>> replace the previous query with a
>
> is this the case that `parserRecoversFromMissingCommaBetweenMediaQueries()`
> exercise?
Yes. We only expect another media condition after a comma, and if there was no
comma, the `if (!expectMediaCondition)` failure path is taken.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2162#discussion_r3279597004