On Thu, 21 May 2026 08:15:00 GMT, Michael Strauß <[email protected]> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use System.out, remove = null assignment which is thankfully not needed in
>> Java (looking at you, C++)
>
> modules/javafx.base/src/main/java/com/sun/javafx/PlatformUtil.java line 298:
>
>> 296: * @implNote To save CPU cycles, animations are not done for
>> embedded
>> 297: */
>> 298: public static boolean isDoAnimations() {
>
> I think we shouldn't hard-code behavior for different platforms, especially
> since the assumption that **all** embedded platforms are totally unable to
> show animations is flawed at best. There are powerful embedded systems.
>
> We've had `Scene.Preferences.reducedMotion` for quite some time now, so we
> should make animations depend on that preference instead. For backwards
> compatibility, we could make `Platform.Preferences.reducedMotion` default to
> `true` on embedded platforms.
I think it should be ok for this PR (corresponds to the status quo), but you do
bring a good point: `isEmbedded()` is extremely vague - is it referring to a
8085 kind of embedded or embedded linux on 2 GHz arm chip?
And what does it mean, exactly? There are a few places that use it currently,
like sub-pixel (LCD) font rendering, some caching in `TitledPaneSkin`, texture
mapping in Phong material, etc.
Perhaps instead we should consider splitting it into individual features like
`low power`, `resource constrained`, `reduced graphic quality` and the like.
What do you think?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2146#discussion_r3290085532
