On Fri, 5 Jun 2026 15:55:44 GMT, Christopher Schnick <[email protected]> wrote:
>> This is a much simpler fix for JDK-8384806 which does not have any side >> effects. >> >> This restores the old code with only a one line change instead. For >> reference, see >> https://github.com/openjdk/jfx/commit/8d917ae738120e12ac12cd0957879b7c00e59b03. >> We now fix the issue by clearing the cell with >> `buttonCell.updateIndex(-1);` as using `buttonCell.setItem(null);` was >> causing the original issue when the item was already null. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Christopher Schnick has updated the pull request incrementally with one > additional commit since the last revision: > > Address review comments modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java line 519: > 517: // They should not change the button cell graphic to null > 518: List<Runnable> methods = List.of( > 519: () -> comboBox.setPromptText("abc"), I think this is probably better as a new separate test. Now we are testing two different operations in one test. Even we end up copy pasting much of this test, I would like a second test only for the `setPromptText` much more ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2179#discussion_r3381147406
