On Sun, 14 Jun 2026 14:53:14 GMT, Michael Strauß <[email protected]> wrote:
>> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 39 commits: >> >> - Remove configurable delays >> - Fix test >> - Xorg fixes >> - Revert "Rewrite WrongStageFocusWithApplicationModalityTest because it >> fails intermittently" >> >> This reverts commit c6b9dd745e5d762adb89a3b596e53b0d8a790d7f. >> - Rewrite WrongStageFocusWithApplicationModalityTest because it fails >> intermittently >> - Use existing verbose flag for GTK >> - Fix window size update >> - StageOwnershipTest: Update Y_DELTA >> - Copyright year >> - Merge branch 'master' into 8354943_v2 >> - ... and 29 more: https://git.openjdk.org/jfx/compare/b690b3c4...68d684f9 > > modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 1193: > >> 1191: } >> 1192: >> 1193: glong to_screen = getScreenPtrForLocation(event->x, event->y); > > `getScreenPtrForLocation()`, which calls `gdk_screen_get_monitor_at_point()`, > expects coordinates "in the virtual screen". You pass in coordinates > specified "relative to its parent", can you verify that this is intended? The parent of a toplevel or a popup (override-redirect) window on X11 is the root window which covers the entire screen. But I've found some problems while testing it and fixed it. > modules/javafx.graphics/src/main/native-glass/gtk/glass_window.h line 73: > >> 71: if (!onChange) return; >> 72: if (notifying) { >> 73: fprintf(stderr,"WARNING: Re-entrant call to >> Observable::invalidate() (possible cyclic dependency)\n"); > > Should this use the `LOG` macro, or alternatively be hidden behind the > `VERBOSE` flag? I think this is closer to an error than a log message. On the other hand, it's something that should be caught during development. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2139#discussion_r3410546793 PR Review Comment: https://git.openjdk.org/jfx/pull/2139#discussion_r3410554009
