On Fri, 19 Jun 2026 20:07:34 GMT, Marius Hanl <[email protected]> wrote:

>> or a regular switch(size()) to minimize the diff
>
> Good idea, although I wonder if we should just straight up remove the 
> `toString()` from here and just put it into the `Node.toString()` method, 
> directly into the `StringBuilder` that is created there anyway.

Moved the logic directly into `Node.toString()` because IMO it makes more sense 
and improves the readability as well. 
Because there is no `toString` method to visually parse anymore in 
`getStyleClass()`.
And in `Node.toString()`, we already have a `StringBuilder` so it got shorter 
and more readable as well (compared to if-else or switch-case).

And wrote tests for the default `Node.toString()` method as well to make sure 
nothing breaks.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2191#discussion_r3448602349

Reply via email to