I think it's a bug^H^H^H "feature" in github UI - only the commenter should be 
able to "resolve" a conversation.

But I found that resolving and collapsing the conversation is somewhat 
counterproductive, since other reviewers might want to see it.

I've been adding an upvote reaction once the particular concern has been 
addressed - a checkmark icon would have been better, but I don't know how to do 
that.

-andy


From: Thiago Milczarek Sayão <[email protected]>
Date: Monday, June 22, 2026 at 03:46
To: openjfx-dev <[email protected]>
Subject: [External] : Question about resolving GitHub review conversations

Hi all,

I have a question about the OpenJFX review workflow.

When a reviewer leaves a comment on a GitHub PR and the author makes the
requested changes, is there a preferred convention for resolving the
conversation?

Should the author mark it as resolved after addressing the comment, or
should it be left for the reviewer to resolve after verification?

Thanks.

Reply via email to