On Tue, 23 Jun 2026 11:21:15 GMT, Marius Hanl <[email protected]> wrote:
>> Tests for the fix made in https://github.com/openjdk/jfx/pull/2171. >> >> I figured out that `ScrollEventTest` already has a way to test `Scene` >> `ScrollEvent`s. >> This is done by invoking the `ScenePeerListener.scrollEvent(..)` method in >> the tests. >> >> This is the very same way the `GlassViewEventHandler` will do in a normal >> application (which is usually invoked from >> `com.sun.glass.ui.View.notifyScroll(..)`). >> >> cc @beldenfox >> This tests the picked `Node` and the `Scene`, if there is no `Node` to pick. >> ~Let me know what you think, I will create a ticket if this is fine!~ Done. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Marius Hanl has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous content of the PR. The pull request contains one new > commit since the last revision: > > Improve assertion messages lgtm. the newly added tests fail in commit 8020a8595426c475ee29a1d09f0abdde6a58e1cf which predates https://github.com/openjdk/jfx/pull/2171 ------------- Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2194#pullrequestreview-4573998148
