On Mon, 29 Jun 2026 17:59:36 GMT, Andy Goryachev <[email protected]> wrote:
>> Ziad El Midaoui has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Minor end of file space issue
>> - Added Copyright header to TextInputControlCaspianTest
>
> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/skin/modena/TextInputControlModenaTest.java
> line 77:
>
>> 75: public void setup() {
>> 76: userAgentStylesheet = Application.getUserAgentStylesheet();
>> 77:
>> Application.setUserAgentStylesheet(Application.STYLESHEET_MODENA);
>
> we could probably do this in `@BeforeClass`, but it does not matter (much),
> only makes the test run slightly longer.
something like this would be good to do
@BeforeAll
public static void setup() {
userAgentStylesheet = Application.getUserAgentStylesheet();
Application.setUserAgentStylesheet(Application.STYLESHEET_MODENA);
}
@AfterAll
public static void cleanup() {
Application.setUserAgentStylesheet(userAgentStylesheet);
}
@AfterEach
public void cleanupTest() {
if (stage != null) {
stage.hide();
stage = null;
}
}
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2184#discussion_r3498560162
