On Tue, 30 Jun 2026 10:50:36 GMT, Ambarish Rapte <[email protected]> wrote:

> Updating GitHub Actions and pinning them to commit SHA value.
> 
> **Checkout**: updated from v6 to v7.0.0: 
> https://github.com/actions/checkout/commit/9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0
> 
> **Gradle wrapper-validation**: same version v6, only pinned to SHA: 
> https://github.com/gradle/actions/commit/11d4d83c63a6ce61b32d8a9c4faddbdb04fe9917
> 
> **Cache**: updated from v5 to v6.1.0: 
> https://github.com/actions/cache/commit/d8cd72f230726cdf4457ebb61ec1b593a8d12337
> - Updating cache to 
> [v6.0.0](https://github.com/actions/cache/commit/b9bf592b98b6a5d0cad9929c76247de1cac78abe)
>  has an issue: GHA build failed: 
> https://github.com/arapte/jfx/actions/runs/28431238316/job/84255662461
> hence updated to v6.1.0
> 
> 
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Two of the hashes are not pointing to the same commit as the tag.

.github/workflows/submit.yml line 62:

> 60:     steps:
> 61:       - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # 
> v7.0.0
> 62:       - uses: 
> gradle/actions/wrapper-validation@11d4d83c63a6ce61b32d8a9c4faddbdb04fe9917 # 
> v6

This isn't the right hash for the tagged action. Rather it is the current HEAD 
commit of master. I see that jtreg bumped the `wrapper-validation` version to 
[6.2.0](https://github.com/openjdk/jtreg/commit/9e7a711647217aa828af4fe881486405136abdbf#diff-3acb0e7569fe716eba818b083b47feb279a0290085f9655e946f21c54d8a947dR14).
 We should do the same. That version is listed as the latest 
[here](https://github.com/gradle/actions/releases/latest).

Make sure that you use a tagged commit.

.github/workflows/submit.yml line 102:

> 100: #      - name: Restore boot JDK from cache
> 101: #        id: bootjdk
> 102: #        uses: actions/cache@d8cd72f230726cdf4457ebb61ec1b593a8d12337 # 
> v6.1.0

This hash is not the tagged commit. It should be 
[55cc8345863c7cc4c66a329aec7e433d2d1c52a9](https://github.com/actions/cache/commit/55cc8345863c7cc4c66a329aec7e433d2d1c52a9)
 -- see [actions/cache/releases](https://github.com/actions/cache/releases).

-------------

Changes requested by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/2199#pullrequestreview-4601434256
PR Review Comment: https://git.openjdk.org/jfx/pull/2199#discussion_r3499659689
PR Review Comment: https://git.openjdk.org/jfx/pull/2199#discussion_r3499871850

Reply via email to