On Tue, 30 Jun 2026 15:16:06 GMT, John Hendrikx <[email protected]> wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/PopupControlTest.java
>> line 122:
>>
>>> 120: popup.getStyleClass().add("Hello");
>>> 121: popup.getStyleClass().add("Goodbye");
>>> 122: assertEquals("[Hello, Goodbye]",
>>> popup.getStyleClass().toString());
>>
>> wouldn't this be a breaking change?
>> if someone is relying on style classes being separated with a space instead
>> of json?
>
> It's a bit odd it was overridden in the first place to do something different
> from what most others `List`s do (although it does look a bit more like what
> you see in CSS that way, but still without the leading dots).
>
> The format is not documented (you'd have to document it on `ObservableList`
> or on the `getStyleClass` method) so we would be allowed to make this change.
> Nobody should be relying on `toString` output, of essentially an
> `ObservableList`, being in a specific format.
so there is a potential for breaking a) `CssParser` and b) some weird
application that relies on the existing behavior for some reason.
two questions then:
1. what is the rationale behind this change?
2. could we demonstrate that at least `CssParser` logic is not broken?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2191#discussion_r3499906659
