On Mon, 1 Jun 2026 19:31:37 GMT, Marius Hanl <[email protected]> wrote:
>> modules/javafx.fxml/src/main/java/com/sun/javafx/fxml/builder/ProxyBuilder.java
>> line 190:
>>
>>> 188: // This is used to support read-only collection/map property.
>>> 189: private Object getReadOnlyProperty(String propName) {
>>> 190: Method getter = findGetter(propName);
>>
>> I wonder if this is the right place for this logic.
>>
>> It looks like the `ArrayListWrapper` is used as a marker container type (the
>> comment seems to be still valid), and the actual logic is handled in
>> `getUserValue()`. I wonder if even an AtomicReference or a simple holder
>> type would work just as well, with the logic handling different types moved
>> to where it's actually used?
>>
>> (this private method getReadOnlyProperty() seems completely unnecessary in
>> the first place)
>
> Mostly wondering the same - why do we have `ArrayListWrapper` but no wrapper
> classes for the other collections? Maybe we can unify / simplify it more.
>
> I did some tests with `@NamedArg` and it really seems to be buggy with more
> advanced usecases like this one
@stechy1 do you have an idea about this?
Since you are most likely the person that knows the most about this logic. Will
help us a lot to review the change
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2167#discussion_r3501654726
