> This PR provides an API for replacing the application menu that JavaFX places 
> in the system menu bar on macOS. The application menu is the one next to the 
> Apple menu that is titled with the application's name and contains the Quit 
> menu item. The JavaFX version of this menu has many limitations so this PR 
> allows a developer to simply replace it outright.
> 
> Technically there’s no reason to restrict this to only one menu so the API 
> allows the developer to specify an observable list of Menus known as the 
> common system menus. Like the current application menu the common menus are 
> present for all JavaFX windows and remain present even if all windows lose 
> focus. Any per-window menus provided by a MenuBar with useSystemMenuBar set 
> will appear alongside the common system menus.
> 
> In addition the PR provides some calls that allow a developer to implement 
> the Hide <app name>, Hide Others, and Show All menu items that are expected 
> in the application menu.

Martin Fox has updated the pull request with a new target base due to a merge 
or a rebase. The incremental webrev excludes the unrelated changes brought in 
by the merge/rebase. The pull request contains eight additional commits since 
the last revision:

 - Merge remote-tracking branch 'upstream/master' into commonmenus
 - Tweaked testing utility that searches NSApp.mainMenu, added tests
 - Merge remote-tracking branch 'upstream/master' into commonmenus
 - New way of testing system menu bar, updated tests
 - Merge remote-tracking branch 'upstream/master' into commonmenus
 - Quick fix for a javadoc issue.
 - Merge remote-tracking branch 'upstream/master' into commonmenus
 - Specify a list of menus that are always present in the system menu bar

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1881/files
  - new: https://git.openjdk.org/jfx/pull/1881/files/e9346431..a3f553b4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1881&range=02
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1881&range=01-02

  Stats: 797474 lines in 10869 files changed: 393299 ins; 267202 del; 136973 mod
  Patch: https://git.openjdk.org/jfx/pull/1881.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1881/head:pull/1881

PR: https://git.openjdk.org/jfx/pull/1881

Reply via email to