On Thu, 2 Jul 2026 22:20:34 GMT, Kevin Rushforth <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move HeaderBar.AttachedProperties to Stage.ExtendedPropertiesImpl
>
> modules/javafx.graphics/src/main/java/javafx/stage/Stage.java line 1346:
>
>> 1344: .map(Scene::getPreferences)
>> 1345:
>> .flatMap(Scene.Preferences::colorSchemeProperty)
>> 1346: .orElse(ColorScheme.LIGHT)) {
>
> Would it be better to map this to
> `PlatformImpl.getPlatformPreferences().colorSchemeProperty()`, which is the
> default when there is a scene, but color scheme hasn't been set?
It makes sense to track the platform color scheme when we have no scene. Since
this is not possible with the fluent API (there's no
`orElse(ObservableValue)`), I've added a custom binding.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2188#discussion_r3516577960
