On Tue, 7 Jul 2026 19:06:55 GMT, Marius Hanl <[email protected]> wrote:
>> Marius Hanl has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits since the last revision: >> >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 833146-mvn-publish >> - all task build the publication now >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 833146-mvn-publish >> - Use defineProperty and fail method from default build.gradle >> - Depend maven publishing on the build modules task >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 833146-mvn-publish >> - remove print >> - Use projects directly >> - Further reduce coupling between main build.gradle and maven-publish.gradle >> - Move MAVEN_GROUP_ID and fail() over to maven-publish.gradle >> - ... and 2 more: https://git.openjdk.org/jfx/compare/642d0931...ea22f852 > > I think this might be a good candidate after RDP1. > @Maran23 as you asked for feedback: I think this is a good first step. Thank you for your feedback and the explanation, really appreciate it. Since the OpenJDK build system is currently being evaluated, I don't think we need to refactor the current `build.gradle` (at least until we know more). The reason why I did the 'Maven publishing' extraction regardless is mostly because of https://github.com/openjdk/jfx/pull/2144 (and well, learning Gradle😀), which makes testing locally much easier. It seems that people like @FlorianKirmaier and @eduardsdv also use this way of testing. For me, this makes it very easy to try a version for many different applications - I just change the JavaFX version in the `pom.xml` or `build.gradle` and can start testing. Additionally, whatever the build system will be in the future, I would still like to support the 'Maven Publishing' process, if possible. So if we can remove most of Gradle, I hope that this refactoring makes it easier to keep the relevant parts we might still need (or, if we don't need Gradle anymore, still enable us developers to use it with our locally installed Gradle on our own). In any case, moving the publishing file into `buildSrc` so it will become a plugin sounds like a good next step. This is something I would like to experiment with, after this PR is merged. (@kevinrushforth, this might be a good discussion for the mailing list?). Not just to follow the convention (and again, learning), but PRs like https://github.com/openjdk/jfx/pull/2156 will again make the `build.gradle` grow and I would rather like to see those as new plugins. And hopefully the insights I gained when doing that will help doing so in the future. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1970#issuecomment-4918145644
