On Thu, 9 Jul 2026 19:48:40 GMT, Kevin Rushforth <[email protected]> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> demos
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/StyleAttribute.java
> line 87:
>
>> 85: */
>> 86: public static <P> StyleAttribute<P> inlineNode(String name, Class<P>
>> type) {
>> 87: return new InlineNodeStyleAttribute<P>(name, type);
>
> Rather than a separate `inlineNode` factory method, could this instead be
> done with a check on the class type in `character()` factory method? I could
> ask the same of the other factory methods, so maybe there is some value in
> doing this way?
not sure I understand the problem here. it's a way to create an inline node
attribute. I don't want to expose a single-purpose constructor or various
types, thus the factory method.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2196#discussion_r3555126387
