On Sat, 11 Jul 2026 15:42:53 GMT, Petr Štechmüller <[email protected]> wrote:
>> modules/javafx.fxml/src/main/java/com/sun/javafx/fxml/builder/ProxyBuilder.java
>> line 592:
>>
>>> 590: strsMap.put(propName, new Getter(m, retType));
>>> 591: } else if (Map.class.isAssignableFrom(retType) &&
>>> argType.length == 0
>>> 592: && !strsMap.containsKey(propName)) {
>>
>> Why is this condition needed (only here?)?
>
> Thanks to this condition it is possible to put all values of a `Map` defined
> inside FXML into a concrete `Map` instance in class. `Map` is not a subtype
> of a `Collection` and same is for `ObservableArray`.
What I meant is only the condition `!strsMap.containsKey(propName)`, was just
wondering because it is only done here and not for the other types
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2167#discussion_r3564563675
