On Sun, 12 Jul 2026 15:03:41 GMT, Marius Hanl <[email protected]> wrote:
>> Petr Štechmüller has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove SuppressWarnings annotation from tests
>
> modules/javafx.fxml/src/test/java/test/com/sun/javafx/fxml/builder/ProxyBuilderTest.java
> line 117:
>
>> 115: pb.put("b", 456);
>> 116: ImmutableClass result = (ImmutableClass) pb.build();
>> 117: assertEquals(123, result.a, 0.00001);
>
> I just saw that below, you were using `1e-5f`, lets use it here and below as
> well
> Suggestion:
>
> assertEquals(123, result.a, 1e-5f);
I have changed this because you asked for change in some other comment. So
should I put `1e-5f` there?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2167#discussion_r3566771169
