On Tue, 14 Jul 2026 21:42:12 GMT, Andy Goryachev <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Clarify doc > > modules/javafx.base/src/main/java/com/sun/javafx/binding/ListenerList.java > line 160: > >> 158: progress = NESTED_NOTIFICATION_ABORTED; // >> Indicate an early exit before notifying all listeners intended at this level >> 159: >> 160: return wasLocked ? false : unlock(); > > you might want to move `unlock()` to the `finally` block, in case a) someone > adds a third return path, and b) in case of an exception. There should not be any exceptions possible though, all paths are either internal code, or guarded already (callChangeListener). I'll take a look. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r3582909264
